[PATCH] D101727: Fix PR47960 - Incorrect transformation of fabs with nnan flag

Fri Jul 16 05:41:13 PDT 2021

spatel added a comment.

In D101727#2879492 <https://reviews.llvm.org/D101727#2879492>, @Krishnakariya wrote:

> Ping @spatel, a gentle reminder. Could you please review the updates on this patch?

I think you missed my earlier comment:
I prefer that we add more tests rather than alter the FMF on the existing tests. We want to be able to verify that all of these flag permutations are behaving as expected. We can commit the baseline tests as a preliminary step, so we just see the diffs in this review. If you do not have commit access, let me know so I can commit for you.

I'd like to have a final patch with no changes to the IR in the original tests; that is, we should still have test coverage for the existing patterns before this patch (and they will show that the transform does not fire any more in several cases). Does that make sense?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101727/new/

https://reviews.llvm.org/D101727