[PATCH] D104464: [LoopIdiom] Transform memmove-like loop into memmove (PR46179)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 18 14:35:16 PDT 2021


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

In D104464#2879515 <https://reviews.llvm.org/D104464#2879515>, @yurai007 wrote:

> In D104464#2848307 <https://reviews.llvm.org/D104464#2848307>, @efriedma wrote:
>
>> Can you add a testcase for a case where both IsMemCpy and UseMemMove are true?  I think you'll end up bailing out due to the alias check, but I'd like to be sure.
>
> Wouldn't you mind if I added memcpy handling in follow-up change?

That's fine; I just wanted to make sure it didn't crash or miscompile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104464/new/

https://reviews.llvm.org/D104464



More information about the llvm-commits mailing list