[PATCH] D105618: [llvm-mca] Fix JSON output for multiple regions

[Marcos Horro via Phabricator via llvm-commits]

markoshorro updated this revision to Diff 357523.
markoshorro marked 3 inline comments as done.
markoshorro added a comment.

"Resources" is now at top-level in the output. I have specialized a bit the InstructionView for printing only once the "Resources" key at top level even when having multiple regions.

I have some doubts about the coding style when having

  if (condition) {
       stmt;
       stmt;
  } else
        stmtelse;

I have put braces surrounding else `stmtelse`, but I am not sure if that is correct...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105618/new/

https://reviews.llvm.org/D105618

Files:
  llvm/test/tools/llvm-mca/JSON/X86/views-multiple-region.s
  llvm/test/tools/llvm-mca/JSON/X86/views.s
  llvm/tools/llvm-mca/PipelinePrinter.cpp
  llvm/tools/llvm-mca/PipelinePrinter.h
  llvm/tools/llvm-mca/Views/InstructionView.cpp
  llvm/tools/llvm-mca/Views/InstructionView.h
  llvm/tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105618.357523.patch
Type: text/x-patch
Size: 28653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210709/6f667436/attachment.bin>