[PATCH] D105618: [llvm-mca] Fix JSON output for multiple regions

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 8 06:39:23 PDT 2021


andreadb added inline comments.


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:601
+      else
+        Printer.printReport(TOF->os());
       continue;
----------------
remove tab.


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:670-675
+    if (PrintJson)
+      JSONOutput.try_emplace(!Region->getDescription().empty()
+                                 ? Region->getDescription().str()
+                                 : "main",
+                             Printer.getJSONReportRegion());
+    else
----------------
Add braces for this then block.


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:676
+    else
+      Printer.printReport(TOF->os());
 
----------------
remove tab.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105618/new/

https://reviews.llvm.org/D105618



More information about the llvm-commits mailing list