[PATCH] D105618: [llvm-mca] Fix JSON output for multiple regions
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 9 08:49:17 PDT 2021
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
LGTM
In D105618#2867209 <https://reviews.llvm.org/D105618#2867209>, @markoshorro wrote:
> "Resources" is now at top-level in the output. I have specialized a bit the InstructionView for printing only once the "Resources" key at top level even when having multiple regions.
>
> I have some doubts about the coding style when having
>
> if (condition) {
> stmt;
> stmt;
> } else
> stmtelse;
>
> I have put braces surrounding else `stmtelse`, but I am not sure if that is correct...
That's fine. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105618/new/
https://reviews.llvm.org/D105618
More information about the llvm-commits
mailing list