[PATCH] D105387: [msan] Handle funnel shifts
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 7 22:30:00 PDT 2021
vitalybuka added a comment.
In D105387#2863058 <https://reviews.llvm.org/D105387#2863058>, @eugenis wrote:
> Instrumentation change LGTM but the test looks way too complicated. I'd edit it down to only check the lines that matter, split to have one intrinsic call per function (that should simplify matching quite a bit) and drop some of the vector-size variants.
It's auto-generated test, manual cleunup will make it impossible auto-update
> I'm also not a fan of adding a test for the broken state before the fix, but up to you. I can see how it is useful during development, but not sure what's the point of having it in git history.
To see the difference.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105387/new/
https://reviews.llvm.org/D105387
More information about the llvm-commits
mailing list