[PATCH] D105387: [msan] Handle funnel shifts

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 13:47:32 PDT 2021


eugenis added a comment.

Instrumentation change LGTM but the test looks way too complicated. I'd edit it down to only check the lines that matter, split to have one intrinsic call per function (that should simplify matching quite a bit) and drop some of the vector-size variants.

I'm also not a fan of adding a test for the broken state before the fix, but up to you. I can see how it is useful during development, but not sure what's the point of having it in git history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105387/new/

https://reviews.llvm.org/D105387



More information about the llvm-commits mailing list