[PATCH] D105387: [msan] Handle funnel shifts

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 23:24:26 PDT 2021


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

OK then, LGTM.

Btw, we are lucky that `setOriginForNaryOp` is right-biased. If both the shift size and one of the other arguments are undefined, we would want to blame the shift size, because the undefined bits from the first 2 arguments may get shifted away. To be precise, we would still want to mask out the extra bits in the shift size argument before using it in the origin computation, but that's a mostly theoretical concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105387/new/

https://reviews.llvm.org/D105387



More information about the llvm-commits mailing list