[PATCH] D105176: [InstrProfiling] Use external weak reference for bias variable

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

If an undefined weak symbol is kept, restricting to ELF only looks fine to me.

> but using LinkOnceODRLinkage results in weak symbol being emitted which leads to an issue where the linker might choose either of the weak symbols potentially disabling the runtime counter relocation.

But I don't understand this sentence from the description. Are you linking libclang_rt.profile-* before other input files?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105176/new/

https://reviews.llvm.org/D105176