[PATCH] D105176: [InstrProfiling] Use external weak reference for bias variable

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

I'm fine disabling this for Mach-O which uses the continuous mode that relies on overmapping (see https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program for more details).

I'll clarify the commit message, the issue is that relying on link order is fragile and can lead to hard-to-notice issues which we observed in practice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105176/new/

https://reviews.llvm.org/D105176