[PATCH] D105176: [InstrProfiling] Use external weak reference for bias variable

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added a comment.

MaskRay's code generation example shows the optimal code possible for implementing this feature and how that code is generated is unaffected by this change, so I don't understand why that subject is being raised here.

As to the linking issues, it may make sense to define things differently for different object formats.  Using the approach taken here for ELF platforms and leaving other platforms to their own devices seems like a sensible plan to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105176/new/

https://reviews.llvm.org/D105176