[PATCH] D105208: [lit] Extend --xfail/LIT_XFAIL to take full test name

Wed Jun 30 12:55:41 PDT 2021

jdenny added a comment.

In D105208#2851016 <https://reviews.llvm.org/D105208#2851016>, @yln wrote:

> In D105208#2850746 <https://reviews.llvm.org/D105208#2850746>, @jdenny wrote:
>
>> This patch just makes it possible to be more precise in specifying tests.
>
> My understanding of this change: a test file/declaration can produce multiple test executions (by being included in multiple test configurations).

It's also conceivable that the same file name might happen to appear in unrelated test suites, but I don't recall actually running into that case.

> Previously, we could only xfail based on test name (suite-relative file path), which meant "all or none" test executions. This patch allows us to also use the fully-qualified test execution name (which includes the test configuration) to be more selective.

Exactly.

> LGTM!  Thanks also for the really good documentation! :)

Thanks for the quick review!  Before pushing, I'll give @davezarzycki a few days to comment as the `--xfail` implementation was his.

> (One thought I had: we could generalize this further by only requiring a substring match instead of an exact match on `file_path` or `full_name`; but probably no need for this right now.)

That's something to think about, but I'm not sure.  My concern is additional unintentional collisions: `foo.c` would match `my/foo.c`, `my/foo.cpp`, and `your/foo.c`.  I feel like suppressing test failures ought to be precise, and I think that's why @davezarzycki decided against regexes here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105208/new/

https://reviews.llvm.org/D105208