[PATCH] D105208: [lit] Extend --xfail/LIT_XFAIL to take full test name
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 30 12:14:02 PDT 2021
yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.
In D105208#2850746 <https://reviews.llvm.org/D105208#2850746>, @jdenny wrote:
> This patch just makes it possible to be more precise in specifying tests.
My understanding of this change: a test file/declaration can produce multiple test executions (by being included in multiple test configurations). Previously, we could only xfail based on test name (suite-relative file path), which meant "all or none" test executions. This patch allows us to also use the fully-qualified test execution name (which includes the test configuration) to be more selective.
LGTM! Thanks also for the really good documentation! :)
(One thought I had: we could generalize this further by only requiring a substring match instead of an exact match on `file_path` or `full_name`; but probably no need for this right now.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105208/new/
https://reviews.llvm.org/D105208
More information about the llvm-commits
mailing list