[PATCH] D105208: [lit] Extend --xfail/LIT_XFAIL to take full test name

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM too.

In D105208#2851144 <https://reviews.llvm.org/D105208#2851144>, @jdenny wrote:

> In D105208#2851016 <https://reviews.llvm.org/D105208#2851016>, @yln wrote:
>
>> (One thought I had: we could generalize this further by only requiring a substring match instead of an exact match on `file_path` or `full_name`; but probably no need for this right now.)
>
> That's something to think about, but I'm not sure.  My concern is additional unintentional collisions: `foo.c` would match `my/foo.c`, `my/foo.cpp`, and `your/foo.c`.  I feel like suppressing test failures ought to be precise, and I think that's why @davezarzycki decided against regexes here.

Yeah, we need to be VERY careful with substring matches, due to the risk of false XFAILs for tests that should be real failures. We don't want real test failures be hidden by accident after all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105208/new/

https://reviews.llvm.org/D105208