[PATCH] D104997: [WIP][AMDGPU] Deduce attributes with the Attributor

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:133
+      }
+    }
+  }
----------------
kuter wrote:
> jdoerfert wrote:
> > There should be at least a todo. We should actually look at all call sites and if that succeeds we can propagate information just fine. Address taken doesn't need to be a bad thing per se.
> I agree, but `simple-indirect-call.ll` depends on this behavior.
Add a fixme for now then.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:206
+    A.checkForAllInstructions(CheckAddrSpaceCasts, *this,
+                              {Instruction::AddrSpaceCast});
+
----------------
kuter wrote:
> jdoerfert wrote:
> > I imagine we need to walk all instructions and look at all operands here, no?
> yes we do.
Or, you start with all globals in the interesting address spaces and make your way down the use chains. Probably cheaper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997