[PATCH] D104997: [WIP][AMDGPU] Deduce attributes with the Attributor

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:206
+    A.checkForAllInstructions(CheckAddrSpaceCasts, *this,
+                              {Instruction::AddrSpaceCast});
+
----------------
jdoerfert wrote:
> kuter wrote:
> > jdoerfert wrote:
> > > I imagine we need to walk all instructions and look at all operands here, no?
> > yes we do.
> Or, you start with all globals in the interesting address spaces and make your way down the use chains. Probably cheaper.
Or, you ask AAMemoryLocation for all globals that can be accessed. The downside is (potentially) that it won't track non-access uses, e.g. `return &shared_mem = ptr;` Unsure if that is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997