[PATCH] D104997: [WIP][AMDGPU] Deduce attributes with the Attributor

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:133
+      }
+    }
+  }
----------------
jdoerfert wrote:
> There should be at least a todo. We should actually look at all call sites and if that succeeds we can propagate information just fine. Address taken doesn't need to be a bad thing per se.
I agree, but `simple-indirect-call.ll` depends on this behavior.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:206
+    A.checkForAllInstructions(CheckAddrSpaceCasts, *this,
+                              {Instruction::AddrSpaceCast});
+
----------------
jdoerfert wrote:
> I imagine we need to walk all instructions and look at all operands here, no?
yes we do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997