[PATCH] D90352: Introduce a Bazel build configuration

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added inline comments.


================
Comment at: utils/bazel/WORKSPACE:76
+    sha256 = "2431088b38fd8e2878db17e3c5babb431de9e5c52b6d8b509d3070fa279a5be2",
+    strip_prefix = "bazel-toolchains-3.3.1",
+    urls = [
----------------
kuhar wrote:
> Is there a reason for using this particular version? I think the most recent release is 4.x.
It was the newest version when we originally wrote these and there hasn't been a major reason to upgrade. I've bumped it to 4.0.0 in https://github.com/google/llvm-bazel/pull/229, which I think is the latest LTS release, if I understand https://blog.bazel.build/2020/11/10/long-term-support-release.html correctly.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/llvm-config.h:74
+/* Major version of the LLVM API */
+#define LLVM_VERSION_MAJOR 12
+
----------------
kuhar wrote:
> This seems outdated. Could we have a script that generates this config file based on one produced with Cmake?
We've looked at various scripting ideas but it's pretty non-trivial. The best we came up with was the current approach of manually specifying everything and then having a test that checks when the config .cmake files change. It looks like this is an example of something that falls through for that because it's only updated in the CMakeLists.txt :-/ For now I'll update this to 13


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352