[PATCH] D90352: Introduce a Bazel build configuration

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added inline comments.


================
Comment at: utils/bazel/WORKSPACE:76
+    sha256 = "2431088b38fd8e2878db17e3c5babb431de9e5c52b6d8b509d3070fa279a5be2",
+    strip_prefix = "bazel-toolchains-3.3.1",
+    urls = [
----------------
Is there a reason for using this particular version? I think the most recent release is 4.x.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/llvm-config.h:74
+/* Major version of the LLVM API */
+#define LLVM_VERSION_MAJOR 12
+
----------------
This seems outdated. Could we have a script that generates this config file based on one produced with Cmake?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352