[PATCH] D90352: Introduce a Bazel build configuration

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/binary_alias.bzl:25
+
+binary_alias = rule(
+    _binary_alias_impl,
----------------
GMNGeoffrey wrote:
> keith wrote:
> > skylib has native_binary which appears to do the same thing as this custom rule
> Oh nice! That looks relatively new. Let me look into swapping that in. I think currently the main repo doesn't have a dependency on skylib because our only usage in the project was for the config diff tests, which dependent users don't need and it seemed like an unnecessary dependency. This would maybe be worth tipping us over the edge.
Hmmm it seems like that requires an explicit out name for some reason, which is pretty annoying. Also does a copy instead of a symlink, which it claims is necessary. Right now I think we get the rule name to be the same as the binary name, which is desirable. Not a huge deal, but at least gives me pause for a moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352