[PATCH] D90352: Introduce a Bazel build configuration

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 16 12:38:04 PDT 2021


keith added inline comments.


================
Comment at: utils/bazel/README.md:29
+   you don't have a checkout yet.
+2. Install Bazel at the version indicated by [.bazelversion](./bazelversion),
+   following the official instructions, if you don't have it installed yet:
----------------
GMNGeoffrey wrote:
> keith wrote:
> > should this mention bazelisk?
> I don't want to repeat Bazel docs or be too opinionated about how exactly someone gets this. Personally I don't use bazelisk and instead use the wrapper shell script that's been around for a while that delegates to the appropriate bazel version (but requires that it be installed). Bazelisk is mentioned in the Bazel install docs we link to, so I think it's ok to defer to them. WDYT?
Yea I think that's fine, it just might mean folks end up here using the wrong version because without bazelisk installing an old version takes more steps


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90352/new/

https://reviews.llvm.org/D90352



More information about the llvm-commits mailing list