[PATCH] D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files

[Maryam via Phabricator via llvm-commits]

MaryamBen added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:580
 bool XCOFFObjectWriter::nameShouldBeInStringTable(const StringRef &SymbolName) {
-  return SymbolName.size() > XCOFF::NameSize;
+  return (SymbolName.size() > XCOFF::NameSize) || TargetObjectWriter->is64Bit();
 }
----------------
Esme wrote:
> `nameShouldBeInStringTable()` will never be called if the `TargetObjectWriter->is64Bit()` is true, right? Maybe we can just remove the or condition.
Actually it's used in XCOFFObjectWriter::executePostLayoutBinding() even for 64 bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103696/new/

https://reviews.llvm.org/D103696