[PATCH] D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files

[Maryam via Phabricator via llvm-commits]

MaryamBen added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:162
+void XCOFFDumper::printRelocations64(ArrayRef<XCOFFSectionHeader64> Sections) {
+  if (!opts::ExpandRelocs)
+    report_fatal_error("Unexpanded relocation output not implemented.");
----------------
jhenderson wrote:
> Do you plan to add support for this? I think it would make more sense to just ignore the option, if there's no strong motivation to crash in this case... (even if you do want a warning/error, use the reportUniqueWarning/reportError functions).
I have no idea why this condition needs to be checked, as I just adapted the existing code for 64-bit, but since it is better to use reportUniqueWarning, I will do so.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103696/new/

https://reviews.llvm.org/D103696