[PATCH] D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files

[Maryam via Phabricator via llvm-commits]

MaryamBen added a comment.

> In D103696#2803251 <https://reviews.llvm.org/D103696#2803251>, @sfertile wrote:
>
>> My first suggestion is we need to break up this patch to make it smaller and easier to review. The natural place to partition it is the llvm-readobj functionality.  I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.
>
> Reiterating this, as I think it is really important. This patch is too large to review as is. I understand breaking it up seems like extra work but it is going to go much faster/smoother if we can partition this into some smaller changes. The first patch I think should be the addition of Relocation64 to the XCOFF implementation in the Object library (ie include/llvm/Object/XCOFFObjectFile.h and lib/ObjectXCOFFObjectFile.cpp), any code needed to support that (for example if additions need to be made to `include/llvm/BinaryFormat/XCOFF.h`) and the 64-bit relocation reading support added to the llvm-readobj XCOFFDumper to exercises the newly added functionality.

You are right, I will break it into two parts.
The first patch for the objectWriter ( PPCXCOFFObjectWriter.cpp, XCOFFObjectWriter.cpp, XCOFF.h and the related tests), the second part for 64-bit relocation support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103696/new/

https://reviews.llvm.org/D103696