[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Patrick Holland via Phabricator via llvm-commits]

holland11 added a comment.

> Could the first argument be `ArrayRef<InstRef> IssuedInst`?

The place that this argument comes from (in the in-order pipeline) is

  class InOrderIssueStage final : public Stage {
    ...
    /// Instructions that were issued, but not executed yet.
    SmallVector<InstRef, 4> IssuedInst;
    ...
    ...
  };

I didn't setup that `SmallVector` and I don't know enough about how those data structures work to know if it would be smart to change it to an ArrayRef or have it get casted into an ArrayRef on its way into the `checkCustomHazard` function (if that's even a possible cast).

I would guess the answer to your question is no, but you probably have more familiarity with these data structures than I do so you probably know better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149