[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.

I am happy to commit this patch for you once you address the minor comment from @foad about the SmallVector.

You can then send the other change to the RegisterFile for review (that would be straightforward), and the rest of the changes to AMDGPU.

Thanks for working on this!

P.s.: if you plan to do more work on llvm then it might be worthy to request commit access.



================
Comment at: llvm/lib/MCA/CustomBehaviour.cpp:20
+unsigned
+CustomBehaviour::checkCustomHazard(const SmallVector<InstRef, 4> &IssuedInst,
+                                   const InstRef &IR) {
----------------
foad wrote:
> Could the first argument be `ArrayRef<InstRef> IssuedInst`?
Yeah, it should be immutable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149