[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 11:13:31 PDT 2021


foad added a comment.

> Made the AMDGPUCustomBehaviour class empty so that we can commit the implementation in a separate patch.

Thanks. Adding the empty AMDGPU class is fine, of course.



================
Comment at: llvm/lib/MCA/CustomBehaviour.cpp:20
+unsigned
+CustomBehaviour::checkCustomHazard(const SmallVector<InstRef, 4> &IssuedInst,
+                                   const InstRef &IR) {
----------------
Could the first argument be `ArrayRef<InstRef> IssuedInst`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149



More information about the llvm-commits mailing list