[PATCH] D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure

[Sushma Unnibhavi via Phabricator via llvm-commits]

sushmaunnibhavi added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:3131
+    // TODO : removing reportTranslationError until big endian is supported
+    // reportTranslationError(*MF, *TPC, *ORE, R);
   }
----------------
aemerson wrote:
> sushmaunnibhavi wrote:
> > aemerson wrote:
> > > sushmaunnibhavi wrote:
> > > > qcolombet wrote:
> > > > > Instead of purely removing it, turn that into a warning.
> > > > @qcolombet , @aemerson 
> > > > Is it right if I do this instead?
> > > > 
> > > > ```
> > > > if (Triple(MF->getTarget().getTargetTriple()).getArch() != Triple::m68k) {
> > > >       reportTranslationError(*MF, *TPC, *ORE, R);
> > > >     }
> > > > ```
> > > > 
> > > > This would not call reportTranslationError only for m68k but would not affect any other targets. 
> > > It's less preferable than a TLI hook because it encodes target specific behavior into the translator.
> > I have created an enableBigEndian() hook which the targets can use if they want to use big-endian. I ran the tests locally and the tests passed. But some of the unit tests fail when I submitted the patch which is not related to globalisel. What could be the reason for that?
> > 
> > I am new to compilers so wanted to know where I am going wrong.
> Which tests are failing? Have you checked if they pass without your changes?
There was a problem with the patch I submitted previously, now with the updated patch no tests fail. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819