[PATCH] D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure

Sushma Unnibhavi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 18:48:33 PDT 2021


sushmaunnibhavi added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:3125
 
   if (!DL->isLittleEndian()) {
     // Currently we don't properly handle big endian code.
----------------
aemerson wrote:
> RKSimon wrote:
> > Would this be better:
> > ```
> > if (!DL->isLittleEndian() && !CLI->enableBigEndian()) {
> > ```
> > I'm not sure if we should always emit at least a warning that big-endian gisel isn't properly supported.
> +1
Ok, I will update the patch with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819



More information about the llvm-commits mailing list