[PATCH] D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 18:36:09 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:573
+  /// enableBigEndian() hook
+  virtual bool enableBigEndian() const { return false; }
+
----------------
arsenm wrote:
> I don't think this should be added. You already know the endianness from the datalayout
The point is that even if a DL says we're using big-endian, without properly implemented and tested support we don't want to actually use GlobalISel. This hook will let us override the fallback for targets like M68K while it's under development.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819



More information about the llvm-commits mailing list