[PATCH] D103014: [lit] Attempt for fix tests failing because of 'warning: non-portable path to file'

Tue Jun 8 08:41:52 PDT 2021

krisb added a comment.

In D103014#2805417 <https://reviews.llvm.org/D103014#2805417>, @Meinersbur wrote:

> In D103014#2799049 <https://reviews.llvm.org/D103014#2799049>, @krisb wrote:
>
>> In D103014#2792673 <https://reviews.llvm.org/D103014#2792673>, @Meinersbur wrote:
>>
>>> Besides the switch from os.path to pathlib, is the change to first build the path, then to resolve it (instead of first using abspath to resolve it, then concat the path) intentional?
>>
>> Oh, surely no. I'll add back resolving first. Thank you for pointing to this!
>
> Now it is resolving twice?!?

I think it would be better to get rid of lots of `\..\..\..\..\` when `path()` is used to construct paths for source, object, and other directories and files within a site config. So this is why I made it resolved twice (the first one for `__file__` to remove symlinks and the second one to simplify the resulting path). What do you think? Does this make sense?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103014/new/

https://reviews.llvm.org/D103014