[PATCH] D103014: [lit] Attempt for fix tests failing because of 'warning: non-portable path to file'

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

In D103014#2805545 <https://reviews.llvm.org/D103014#2805545>, @krisb wrote:

>> Now it is resolving twice?!?
>
> I think it would be better to get rid of lots of `\..\..\..\..\` when `path()` is used to construct paths for source, object, and other directories and files within a site config. So this is why I made it resolved twice (the first one for `__file__` to remove symlinks and the second one to simplify the resulting path). What do you think? Does this make sense?

I originally asked whether changing the point where resolve is called is intentional, and this seems to be the intention (although unrelated to this patch). The second call will resolve all the paths of `__file__` as well, making the first resolve redundant.

Greenlighting the patch, but please remove the first call to `resolve()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103014/new/

https://reviews.llvm.org/D103014