[PATCH] D103014: [lit] Attempt for fix tests failing because of 'warning: non-portable path to file'

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 8 07:17:20 PDT 2021


Meinersbur added a comment.

In D103014#2799049 <https://reviews.llvm.org/D103014#2799049>, @krisb wrote:

> In D103014#2792673 <https://reviews.llvm.org/D103014#2792673>, @Meinersbur wrote:
>
>> Besides the switch from os.path to pathlib, is the change to first build the path, then to resolve it (instead of first using abspath to resolve it, then concat the path) intentional?
>
> Oh, surely no. I'll add back resolving first. Thank you for pointing to this!

Now it is resolving twice?!?

@thakis To not get lost in nitpicking, I would accept this unless you have objections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103014/new/

https://reviews.llvm.org/D103014



More information about the llvm-commits mailing list