[PATCH] D103659: [AMDGPU][GlobalISel] Try to use op_sel when selecting packed instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 03:58:46 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3468
+
+  SmallVector<int, 2> Mask = {0, 1};
+  // Match op_sel through G_SHUFFLE_VECTOR or set mask values if a possibiliy
----------------
SmallVector is overkill, just use `int Mask[2]`? Or std::array if you want more type safety.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103659/new/

https://reviews.llvm.org/D103659



More information about the llvm-commits mailing list