[PATCH] D103502: Bug 41152 - [DebugInfo] Better dumping of empty location expression

[Soham Dixit via Phabricator via llvm-commits]

sohamdixit updated this revision to Diff 349759.
sohamdixit added a comment.

Update Revision D103502 <https://reviews.llvm.org/D103502>: Bug 41152 - [DebugInfo] Better dumping of empty location expression


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103502/new/

https://reviews.llvm.org/D103502

Files:
  llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
  llvm/test/MC/X86/dwarf-size-field-overflow.test


Index: llvm/test/MC/X86/dwarf-size-field-overflow.test
===================================================================
--- llvm/test/MC/X86/dwarf-size-field-overflow.test
+++ llvm/test/MC/X86/dwarf-size-field-overflow.test
@@ -6,7 +6,7 @@
 #
 # CHECK:       0x0000004d:       DW_TAG_formal_parameter
 # CHECK-NEXT:      DW_AT_location   (0x00000000
-# CHECK-NEXT:           [0x0000000000000000,  0x0000000000000008): )
+# CHECK-NEXT:           [0x0000000000000000,  0x0000000000000008): <empty>)
 # CHECK-NEXT:      DW_AT_name   ("self")
 
 import sys
Index: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
@@ -326,6 +326,9 @@
                             bool IsEH) const {
   uint32_t EntryValExprSize = 0;
   uint64_t EntryValStartOffset = 0;
+  if (Data.getData().empty()){
+  OS << "<empty>";
+  	}
   for (auto &Op : *this) {
     if (!Op.print(OS, DumpOpts, this, RegInfo, U, IsEH)) {
       uint64_t FailOffset = Op.getEndOffset();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103502.349759.patch
Type: text/x-patch
Size: 1107 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210604/3f933fd5/attachment.bin>