[PATCH] D103502: Bug 41152 - [DebugInfo] Better dumping of empty location expression

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:329
   uint64_t EntryValStartOffset = 0;
+  if (Data.getData().size()==0){
+  	OS << "(empty)";
----------------
dblaikie wrote:
> SouraVX wrote:
> > How about factoring this as:
> > ```
> > if (!Data.getData().size())
> >   OS << "(empty)";
> > 
> > ```
> Probably best to go the whole way:
> ```
> if (Data.getData().empty())
>   OS << "(empty)";
> ```
> ?
Below we're using <> to signal out-of-band errors like <unknown register>, so perhaps this should be `"<empty>"`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103502/new/

https://reviews.llvm.org/D103502