[PATCH] D103502: Bug 41152 - [DebugInfo] Better dumping of empty location expression

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 3 21:23:00 PDT 2021


dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:330
+  if (Data.getData().empty()){
+  OS << "<empty>";
+  	}
----------------
Indentation (please run the change through clang-format (only the changed lines, there's a utility that can do this (reformat only the changed lines) for you - in clang/tools/clang-format/git-clang-format)

And also probably remove the braces - LLVM code doesn't usually use braces on single line blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103502/new/

https://reviews.llvm.org/D103502



More information about the llvm-commits mailing list