[PATCH] D103502: Bug 41152 - [DebugInfo] Better dumping of empty location expression

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:329
   uint64_t EntryValStartOffset = 0;
+  if (Data.getData().size()==0){
+  	OS << "(empty)";
----------------
SouraVX wrote:
> How about factoring this as:
> ```
> if (!Data.getData().size())
>   OS << "(empty)";
> 
> ```
Probably best to go the whole way:
```
if (Data.getData().empty())
  OS << "(empty)";
```
?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103502/new/

https://reviews.llvm.org/D103502