[PATCH] D103139: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

Wed May 26 05:05:10 PDT 2021

hsmhsm added a comment.

In D103139#2781720 <https://reviews.llvm.org/D103139#2781720>, @JonChesterfield wrote:

> Same objection to previous diffs with this code in. You're adding loads of complicated code to an existing pass.
>
> Instead, this independent optimisation should be a separate pass that is scheduled before the lowering. That way it can't break the lowering and the optimization can be tested in isolation, making for simpler and more effective test cases.

I do not agree with you anymore.

Don't you remember that, in the meeting held on Friday 21,  for various reasons, we all of us (including you) agreed to add pointer replacement related code in this pass itself, instead of a separate pass?

What is compilcated code here? I cleanly separated pointer replacement implementation from lowering implementation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103139/new/

https://reviews.llvm.org/D103139