[PATCH] D103139: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield requested changes to this revision.
JonChesterfield added a comment.
This revision now requires changes to proceed.

Same objection to previous diffs with this code in. You're adding loads of complicated code to an existing pass.

Instead, this independent optimisation should be a separate pass that is scheduled before the lowering. That way it can't break the lowering and the optimization can be tested in isolation, making for simpler and more effective test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103139/new/

https://reviews.llvm.org/D103139