[PATCH] D103139: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

I see that. However, we are working on a multipass compiler with a clearly delimited format used between passes.

If your optimisation is written standalone, it can be tested directly. The output doesn't have to embed the lowering pass semantics. It is also easier to write as a separate pass. You have the utils header for sharing code between the two.

I agreed to Stas making the minor adjustments to generalise the lowering pass, for use lowering a function as well as a module. I definitely did not, and do not, agree to splicing an optimisation through the lowering code.

I'm also expecting the optimisation in question to pessimise openmp code, so want to keep an option to disable it from the pipeline when building openmp applications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103139/new/

https://reviews.llvm.org/D103139