[PATCH] D102925: [RISCV] Add wrong arch attribute objfile test.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D102925#2776234 <https://reviews.llvm.org/D102925#2776234>, @khchen wrote:

> update test to show asm has F instructions.
>
> This patch is going to fix wrong attribute for a standalone function or
> all functions have same target feature when -march string is missing.
>
> But I feel that you are talking about another problem,
> something like how to handle different target feature in the same compilation unit or in
> different compilation units. This is not what I want to fix.
>
> Do you still feel this fixed is redundant?

Your patch breaks valid use cases like the one I linked. Please re-read what I said where I explain what the only viable solution I can see is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102925/new/

https://reviews.llvm.org/D102925