[PATCH] D102759: [AArch64ISelDAGToDAG] Supplement cases for ORRWrs/ORRXrs when calculating usefulbits

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 04:23:35 PDT 2021


mdchen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-isel-or.ll:13
+; Function Attrs: norecurse nounwind readnone
+define dso_local i32 @_Z1aii(i32 %b, i32 %c) local_unnamed_addr {
+entry:
----------------
This function is irrelevant to the issue and could be removed I think.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-isel-or.ll:58
+  store i8 0, i8* @d, align 4, !tbaa !5
+  tail call void (...) @printf(i8* getelementptr inbounds ([4 x i8], [4 x i8]* @.str, i64 0, i64 0), i32 %or.10)
+  ret i32 0
----------------
The test case is not supposed to do output. Please remove the `printf` here; also the consequently unused declaration and other related elements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102759/new/

https://reviews.llvm.org/D102759



More information about the llvm-commits mailing list