[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-aux-wrong64.test:19
+# CHECK-NEXT:     612e7300 00000000 00000000 00000000
+# CHECK-NEXT: 00fb  }
+# CHECK-NEXT: ]
----------------
jasonliu wrote:
> jhenderson wrote:
> > The output on this line looks incorrect to me. Possibly a bug in the code resulting from a missing newe line?
> I added an newline after all the raw bytes. Other than that, I think the output is good. We have 18 bytes per symbol table entry, and we are printing 18 raw bytes here. 
I don't know if it is, but you probably want `00fb` indented to line up nicely with the previous line. You can then confirm that this indentation is maintained by enabling `--match-full-lines` and `--strict-whitespace` in FileCheck. (If you do that, you'll need to remove the space after `CHECK-NEXT:`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774