[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 17 08:51:44 PDT 2021
jasonliu marked 2 inline comments as done.
jasonliu added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/file-aux-wrong64.test:19
+# CHECK-NEXT: 612e7300 00000000 00000000 00000000
+# CHECK-NEXT: 00fb }
+# CHECK-NEXT: ]
----------------
jhenderson wrote:
> The output on this line looks incorrect to me. Possibly a bug in the code resulting from a missing newe line?
I added an newline after all the raw bytes. Other than that, I think the output is good. We have 18 bytes per symbol table entry, and we are printing 18 raw bytes here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85774/new/
https://reviews.llvm.org/D85774
More information about the llvm-commits
mailing list