[PATCH] D102509: [lld][X86] Restore gotEntrySize and gotPltEntrySize.

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added a comment.

In D102509#2760035 <https://reviews.llvm.org/D102509#2760035>, @MaskRay wrote:

> We shouldn't need both GotEntrySize and GotPltEntrySize. One is sufficient.

Alright, will update to have just GotEntrySize.



================
Comment at: lld/test/ELF/x86-x32-plt.s:1
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux-gnux32 %s -o %t.o
----------------
MaskRay wrote:
> Don'y copy x86-64-plt.s. Newer tests prefer `#`
> 
> Consider riscv-plt.s
I'd like to avoid unnecessary differences between this and x86-64-plt.s since they both basically test the same thing, just for slightly different targets. Will adjust the other test as well to keep them similar, same for the other comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102509/new/

https://reviews.llvm.org/D102509