[PATCH] D102509: [lld][X86] Restore gotEntrySize and gotPltEntrySize.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/x86-x32-plt.s:1
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux-gnux32 %s -o %t.o
----------------
hvdijk wrote:
> MaskRay wrote:
> > Don'y copy x86-64-plt.s. Newer tests prefer `#`
> > 
> > Consider riscv-plt.s
> I'd like to avoid unnecessary differences between this and x86-64-plt.s since they both basically test the same thing, just for slightly different targets. Will adjust the other test as well to keep them similar, same for the other comments.
please don't copy x86-64-plt.s. i'll improve x86-64-plt.s shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102509/new/

https://reviews.llvm.org/D102509