[PATCH] D102509: [lld][X86] Restore gotEntrySize and gotPltEntrySize.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

We shouldn't need both GotEntrySize and GotPltEntrySize. One is sufficient.



================
Comment at: lld/test/ELF/x86-x32-plt.s:1
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux-gnux32 %s -o %t.o
----------------
Don'y copy x86-64-plt.s. Newer tests prefer `#`

Consider riscv-plt.s


================
Comment at: lld/test/ELF/x86-x32-plt.s:7
+// RUN: ld.lld %t.o %t2.so -o %t3
+// RUN: llvm-readobj -S -r %t | FileCheck %s
+// RUN: llvm-objdump -d --no-show-raw-insn %t | FileCheck --check-prefix=DISASM %s
----------------
Most tests llvm-readelf should be used. Its output is succinct.


================
Comment at: lld/test/ELF/x86-x32-plt.s:59
+
+// DISASM:      Disassembly of section .plt:
+// DISASM-EMPTY:
----------------
This line is not useful.


================
Comment at: lld/test/ELF/x86-x32-plt.s:62
+// DISASM-NEXT: <.plt>:
+// DISASM-NEXT:   1210:       pushq 8354(%rip)
+// DISASM-NEXT:               jmpq *8356(%rip)
----------------
The comment after the instruction is useful. It computes the target address.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102509/new/

https://reviews.llvm.org/D102509