[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 13 12:22:35 PDT 2021


DiggerLin added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:402
+    else
+      printCsectAuxEnt(*ErrOrCsectAuxRef);
+
----------------
we have iterated auxiliary entries from line 382~396 and reiterated again  in the printCsectAuxEnt(). I think we can improve on it.

And in 64bits,  The  auxiliary entries  maybe be reordered in above implement.
 it will print out all no AUX_CSECT auxiliary entries first and then AUX_CSECT entry, even if the AUX_CSECT  is in the middle of the auxiliary entries
and if there are two AUX_CSECT  on auxiliary entries, we only print out one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774



More information about the llvm-commits mailing list