[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked 2 inline comments as done.
jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:402
+    else
+      printCsectAuxEnt(*ErrOrCsectAuxRef);
+
----------------
DiggerLin wrote:
> we have iterated auxiliary entries from line 382~396 and reiterated again  in the printCsectAuxEnt(). I think we can improve on it.
> 
> And in 64bits,  The  auxiliary entries  maybe be reordered in above implement.
>  it will print out all no AUX_CSECT auxiliary entries first and then AUX_CSECT entry, even if the AUX_CSECT  is in the middle of the auxiliary entries
> and if there are two AUX_CSECT  on auxiliary entries, we only print out one.
I don't think we reiterated again in printCsectAuxEnt() for other auxiliary entries. 
We did similar things for 382~396 in `getXCOFFCsectAuxRef`, but that function is specifically designed to only get XCOFFCsectAuxRef. So it's really not intended to pass information out there.
I don't really think the re-iteration should be a big concern because in theory 382~396 won't be executed all that much. If it does, I would rather have it implement properly (i.e. actually recognize the missing auxiliary entry) instead of just printing out raw datas.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85774/new/

https://reviews.llvm.org/D85774